borinquenkid commented on PR #16631: URL: https://github.com/apache/grails-core/pull/16631#issuecomment-6294424723
Pushed two small commits on top of a3f5590b08, @jdaugherty — shout if you'd rather have them elsewhere. **97e21ab3e9 (build-logic): report a module's `cli` source set to JaCoCo.** The aggregate fed JaCoCo only each module's `main` classes and sources, so the eight command classes under `grails-datamapping-core/src/cli` (~610 lines: collapser, reader, renderer, runner, summary, options, mode, type) were absent from the report and from Codecov — the 85% patch figure covered only the `main` tier. `testCli`'s exec data was already collected; it just had no classes to match. `GrailsJacocoPlugin` now adds the `cli` source set whenever a module has one, with a case in `GrailsJacocoPluginSpec`. Regenerating the aggregate locally (`testCli jacocoAggregateReport`) now shows the tier: 299 lines covered, 9 missed (`SqlTailRunner` 7, `SqlStatementCollapser` 2). This gap is pre-existing — grails-core's `src/cli` has the same blind spot — so happy to split it into its own PR if you prefer. **13d66f218e (test): the mkdirs branch of `SqlTailCapture.open`** (`:57`), the one line your a3f5590b08 left: the capture creating its parent directory rather than finding it. Everything else Codecov listed as missing in `grails-datamapping-core` is covered by your commit; the remaining `GrailsGradlePlugin` / `GrailsPropertyArgumentProvider` lines run in TestKit's daemon, where JaCoCo can't see them. Locally on this head: sqltail specs 33 passed (1 skipped: the `/dev/full` case, Linux only), `codenarcTest` clean; `GrailsJacocoPluginSpec` 7/7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
