borinquenkid commented on PR #16656:
URL: https://github.com/apache/grails-core/pull/16656#issuecomment-6293108107
Thanks @matrei. All four are in 5fddfb85fa, which is the branch squashed to
one commit and rebased onto the current `7.0.x`:
1. **Squashed and retitled.** The commit keeps the headline of 83089c549b,
and the PR title now matches it. The withdrawn "circular loses data" wording is
gone from the history.
2. **Guide example.** The circular paragraph now opens with the `User` class
(`hasMany` + `mappedBy`, the same shape as the spec's `WarnCircular`), so
`addToFollowing` and `removeFromFollowing` refer to something the reader has
seen.
3. **Delete note.** Added your text and snippet: remove the user from both
sides with `.toList().each { ... }`, then `delete()`, otherwise the delete
fails on a foreign key.
4. **Smaller points.** The guide ends with a single newline, and the spec's
class javadoc now says "never stored, unless a `Map` side or a circular mapping
writes the join table".
Also picked up by the rebase: 72cac1bb3d, the `7.0.x` fix for the
`FileSystemInteractionImplSpec` Windows failure that was the one red job.
Locally on this head: `ManyToManyWithoutOwnerWarningSpec` 8/8 and
`codenarcTest` clean on `grails-data-hibernate5-core`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
