jamesfredley opened a new pull request, #16736:
URL: https://github.com/apache/grails-core/pull/16736

   Fixes #16567
   
   `dataSource.properties.maximumPoolSize` in `application.yml` never reached 
HikariCP. The datasource bean is built from the Spring `Environment`, and 
`Environment.getProperty("dataSource.properties", Map)` does not return a 
nested map. The keys exist only as flattened entries such as 
`dataSource.properties.maximumPoolSize`. URL, username, and password still 
bound because they are scalars. The empty properties map also meant the Hikari 
binder never ran, so the cached pool stayed at Hikari's defaults.
   
   When a direct map lookup is empty, rebuild the map from enumerable 
property-source keys under that prefix. An existing non-empty map is left 
unchanged, so the Grails config path is unaffected. A malformed map value with 
no flattened children still fails.
   
   No application change is required. The generated `application.yml` block 
works as written.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to