codeconsole commented on PR #16130: URL: https://github.com/apache/grails-core/pull/16130#issuecomment-6399806598
Thanks for the re-review. All four taken, in 6f172d6c29 and de97cb7911: - The upgrade guide now leads with installing the variables before the application context is created, through the `environment` of the Gradle test task or an extension that runs before the context starts, as the supported approach, and presents `refresh()` as a method of the implementation that compiles only dynamically and may change with it. It stays available for a test that can only install variables after startup. - `refreshSystemEnvironment()` is package-private; `PropertySourcesConfig.refresh()` in the same package is its only caller and `PropertySourcesConfig` its only subclass. - The what's new entry keeps the two things a user can observe, the environment read once and the order of installing variables or calling `refresh()`, and drops the sentence about the walk. - The scalar-walk pin in `PropertySourcesConfigSpec` carries a comment naming #16732, which makes such a key absent on 9.0.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
