jamesfredley commented on PR #16721: URL: https://github.com/apache/grails-core/pull/16721#issuecomment-6481592826
Addressed the requested changes in 2aa15fcc16. 1. `DomainClassArtefactHandler.isDomainClass(Class, boolean)` walks every generated layer. `DomainClassArtefactHandlerSpec` covers a one-layer proxy, a two-layer wrapper, a plain class, and null. The test uses a runtime `grails.*` `Entity` annotation because the `@Artefact` transform does not run in that unit test, and that annotation is the marker `isDomainClass` already accepts. 2. Both Hibernate specs assert `findStaticApi` and `findInstanceApi` identity, along with the validation API. 3. The superclass-depth assertion is gone. The specs check that the proxy class is not the entity and that `NameUtils.getClassName` resolves the entity name. 4. The alias feature and the `entityAlias` locals are removed. 5. `getClassName` takes `Class<?>` and its javadoc says a `$` in the simple name is treated as a generated subclass. 6. `findEntity` on `GormApiResolver` and `GormEnhancer` looks the persistent entity up through `NameUtils.getClassName`. `GormApiResolverSpec` covers the Hibernate 5 stock proxy name, which has no trailing `$`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
