jdaugherty commented on PR #16795:
URL: https://github.com/apache/grails-core/pull/16795#issuecomment-6510845698
@codeconsole @jamesfredley thanks, review 5704781240 is addressed in
9d98b7d677:
- `GrailsPlaceholderConfigurer`: `createPropertyResolver` adds the list
source only when `environmentProperties`, the source Spring adds for the
environment, is among the selected sources. A configurer given its own sources
through `setPropertySources` resolves placeholders from those alone, for lists
and scalars alike, as Spring's does. The Javadoc says so.
- `GrailsPlaceholderConfigurerSpec`: a data-driven feature registering the
configurer with its own sources, with none, with one unrelated
`MapPropertySource`, and with the environment among them, injecting
`${app.names:fallback}` and `${app.scalar:fallback}`. The two rows without the
environment fail on 40f143239e with `first,second`; all 18 features pass on the
new head.
Run locally: `:grails-core:test --tests
grails.spring.GrailsPlaceholderConfigurerSpec` and `:grails-core:codeStyle`.
The branch still merges into 8.0.x and 9.0.x without conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
