jdaugherty commented on code in PR #16794:
URL: https://github.com/apache/grails-core/pull/16794#discussion_r4419745960
##########
grails-data-docs/stage/build.gradle:
##########
@@ -105,19 +105,33 @@ tasks.register('copyHibernate5Docs', Sync).configure {
Sync it ->
it.outputs.dir(targetDir)
}
+tasks.register('copyGraphqlDocs', Sync).configure { Sync it ->
+ it.dependsOn(':grails-data-graphql-docs:docs')
+
+ def graphqlSourceDir =
project(':grails-data-graphql-docs').layout.buildDirectory.dir('docs')
+ def targetDir =
project.layout.buildDirectory.dir('graphql-api/grails-data/graphql')
+
Review Comment:
Fixed in 8d9eb6dae8. The introduction now says the `browser` action serves a
GraphiQL page the application supplies and responds 404 until it does; the
table row gives the setting as true in `development` and false elsewhere; and a
new GraphiQL Browser section under Configuration explains the `graphiql.html`
classpath resource and the `{endpoint}` and `{staticBase}` placeholders the
controller replaces.
One nuance on the default: the plugin's own `plugin.yml` sets
`grails.gorm.graphql.browser: true` under `environments.development`, and
`GrailsEnvironmentPostProcessor` loads that file with the environment block
applied, so in development the flag is on and the 404 comes from the missing
page rather than from the setting. The manual states both.
Rebuilding the manual also showed that all 25 of its source includes still
used the standalone repository layout (`examples/...`, `core/...`) and rendered
as unresolved directives; 42664e95ad points them at
`grails-test-examples/graphql` and `grails-data-graphql/core`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
