jdaugherty commented on PR #16792: URL: https://github.com/apache/grails-core/pull/16792#issuecomment-6500589856
I approved, but longer term we should consider using a generic enum to hold these values so it's easy to refer to that enum for what runs where. Then in the code instead of hard coding HIGHEST_PRECEDENCE + 1, we just have GrailsFilterOrder.FILTERNAME - so people can self discover and it's easier to maintain longer term. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
