borinquenkid commented on PR #16784: URL: https://github.com/apache/grails-core/pull/16784#issuecomment-6525161398
Pushed commit d316d92b34 addressing the review feedback: 1. **Closed outer session holder unbind/restore**: In `OuterSessionLifecycleStrategy.from(...)`, routes to `DefaultOuterSessionStrategy` whenever `previousHolder != null` regardless of `session.isOpen()` state, ensuring bound holders for closed outer sessions are suspended before `withNewSession` binds its session and restored on cleanup. Added specification coverage in `WithNewSessionNonLazyPoolSpec`. 2. **Post-callback flush exception translation**: Moved `flushIfNecessary(rawSession, existingTransaction)` inside `executeInSession` so Hibernate flush exceptions are translated to Spring `DataAccessException`. Added specification in `GrailsHibernateTemplateSpec`. 3. **Spec cleanups**: Differentiated duplicate test names in `WithNewSessionLazyLoadSpec` and updated `OuterSessionLifecycleStrategySpec` expectations for bound holders with closed or null sessions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
