jdaugherty commented on PR #16772:
URL: https://github.com/apache/grails-core/pull/16772#issuecomment-6526115619
@jamesfredley @matrei: two commits on top of a3a02b0618, pushed to the PR
branch; the head is a4290530f5.
- e541a498af answers the open thread on `NavigableMap.groovy:426`.
`holdsPath` looks up every dotted start of the name that the map holds as a key
and walks the rest through maps, as matrei's suggestion does, so `put('a.b',
[c: 'x'])` then `merge(['a[b.c]': 'x'], true)` exports `a.b.c=x` and `a[b.c]=x`
in either order. Both orders are rows in the exact-export table in
`ConfigMapSpec` and fail at a3a02b0618. The javadoc of `removeDottedDuplicates`
records the shape that stays dropped, `put('a', ['b.c': 'x'])`, which is stored
as merging `a[b.c]` is.
- a4290530f5 takes the `CompositeConfig` javadoc wording from matrei's nit:
`toProperties()` is the export that leaves the dotted name out, while
`flatten()` combines the stored maps, which never hold it.
Locally the `grails-bootstrap` suite and the `org.grails.config` and
`grails.config` specs in grails-core pass, 468 tests in all, and `codeStyle`
passes for both modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
