matrei opened a new pull request, #16839: URL: https://github.com/apache/grails-core/pull/16839
## Description `gradle/test-config.gradle` configures every `Test` task in a `configureEach` that runs after the build script that applies it, and it assigned `excludes`, so the settings the test suites made before applying it were replaced or overridden. This removes the settings that had stopped doing anything, and the isolation that had stopped isolating. - `grails-test-suite-web`: `test` excluded 12 class patterns so that `execIsolatedTests` could run them with `forkEvery = 1`. The `excludes` assignment of `test-config.gradle` (since 26d5c0ec08, 2025-03-30) replaced the exclusion, so the 9 of those classes that still exist (52 tests) ran in `test` as well as in `execIsolatedTests`, and the shared `forkEvery` has overridden the 1 since a58aa145cf (2025-04-18). They have run in the shared JVMs of `test` since then and pass there, so `execIsolatedTests`, its list, `createCombinedReport`, and the `forkEvery`, `maxParallelForks` and `excludes` that `test-config.gradle` sets anyway go. Three of the patterns matched nothing: `GroovyPageAttributesTests` is in `grails-gsp/grails-taglib` now, and `GSPResponseWriterSpec` and `pages/ext/jsp` are gone. - `grails-test-suite-persistence`: the three classes it excluded from `test` and isolated (`GrailsDomainBinderTests`, `ComponentValidationTests`, `HibernateMappingUniqueConstraintTests`) no longer exist, and its `testGrailsDomainBinder` and `testIsolatedPersistentOne` tasks were NO-SOURCE, as a `Test` task registered without `testClassesDirs` is. Its `forkEvery = 25` and local 2 GB heap were overridden. All of it goes. - `grails-test-suite-uber`: `isolatedTestsOne` named `DefaultGrailsControllerClassSpec`, which is in `grails-core` now. Uber filters its isolated classes by name and does not apply `test-config.gradle`, so its other isolated tasks work as they should. - `grails-test-report`: `execIsolatedTests` leaves its list of isolated phases. - `gradle/test-config.gradle` adds its excludes with `exclude(...)` rather than assigning them, so the excludes a module sets before applying it survive. ### Verification - The effective settings of every `Test` task in the build (`forkEvery`, `maxParallelForks`, heap, excludes, includes and filters), printed before and after the change, differ only in the removed tasks and the removed uber pattern. No other module's excludes were being replaced, so the `exclude(...)` change leaves every remaining task as it was. - `:grails-test-suite-web:check`, `:grails-test-suite-persistence:check` and `:grails-test-suite-uber:check` pass: web 84 classes and 490 tests, persistence 13 and 114, uber's `test` 122 and 624 and its five isolated tasks 10 and 42. - `./gradlew clean aggregateViolations --continue` passes. #16837 also changes `gradle/test-config.gradle` and `grails-test-suite-uber/build.gradle`, on other lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
