[
https://issues.apache.org/jira/browse/GROOVY-7558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107605#comment-15107605
]
ASF GitHub Bot commented on GROOVY-7558:
----------------------------------------
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/242#discussion_r50188030
--- Diff:
src/main/org/codehaus/groovy/transform/sc/StaticCompilationVisitor.java ---
@@ -123,9 +123,20 @@ public void visitClass(final ClassNode node) {
}
super.visitClass(node);
addPrivateFieldAndMethodAccessors(node);
+ if (isStaticallyCompiled(node)) {
+ ClassNode outer = node.getOuterClass();
+ if (outer != null && !isStaticallyCompiled(outer)) {
+
outer.putNodeMetaData(StaticCompilationMetadataKeys.DYNAMIC_OUTER_NODE, true);
+ }
+ }
classNode = oldCN;
}
+ public void visitDynamicOuterClass(ClassNode node) {
--- End diff --
adding a public method here is not ideal, though it seems like the
alternative would be to create a separate class responsible for adding bridge
methods, which would be used by StaticCompilationVisitor as well as the phase
operation added for dynamic outer classes.
> Error when referencing private member variables from within a closure
> ---------------------------------------------------------------------
>
> Key: GROOVY-7558
> URL: https://issues.apache.org/jira/browse/GROOVY-7558
> Project: Groovy
> Issue Type: Bug
> Components: Static compilation
> Affects Versions: 2.4.4
> Environment: Linux x86-64 / java 1.8.0_60
> Reporter: Jon Keys
> Assignee: Cédric Champeau
>
> Originally posted on SO here:
> http://stackoverflow.com/questions/32212260/in-groovy-is-it-legal-to-reference-private-member-variables-from-within-a-closur
> The code below fails with {{java.lang.ClassCastException:
> Test$_doStuff_closure1 cannot be cast to Test}}. Interestingly, if I remove
> the {{@CompileStatic}} annotation or make the member variable non-private it
> works as expected.
> {code:java}
> class Test {
> private String str = "hi"
> @groovy.transform.CompileStatic
> public void doStuff() {
> Closure c = {
> println str
> }
> c()
> }
> }
> new Test().doStuff()
> {code}
> It also works when {{@CompileStatic}} is moved up to the class level
> {code:java}
> @groovy.transform.CompileStatic
> class Test {
> private String str = "hi"
> public void doStuff() {
> Closure c = {
> println str
> }
> c()
> }
> }
> new Test().doStuff()
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
