GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/389
findbugs fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy findbugs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/389.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #389
----
commit a1d6669c2eade9a32bdc4a1dd19ae093b5469c92
Author: John Wagenleitner <[email protected]>
Date: 2016-08-21T21:46:58Z
findbugs: impossible instanceof
loop.getBooleanExpression() can't return a ConstantExpression and the if
branch never executed.
commit 663f6409030ca94a478302703f45bac1f25d2804
Author: John Wagenleitner <[email protected]>
Date: 2016-08-21T22:25:41Z
findbugs: impossible cast
removed cast that would always fail and added some basic tests.
commit 1f61f67e409783547c49662894404d12bb56f6a7
Author: John Wagenleitner <[email protected]>
Date: 2016-08-21T23:14:55Z
findbugs: un-callable method in anonymous class
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
