Github user jwagenleitner commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/438#discussion_r83096173
  
    --- Diff: 
subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/completion/ImportsSyntaxCompletor.groovy
 ---
    @@ -87,51 +78,49 @@ class ImportsSyntaxCompletor implements 
IdentifierCompletor {
             return foundMatch
         }
     
    -    private static final String STATIC_IMPORT_PATTERN = ~/^import static 
([a-z0-9]+\.)+[A-Z][a-zA-Z0-9]*(\.(\*|[^.]+))?$/
    +    private static final String STATIC_IMPORT_PATTERN = ~/^static 
([a-zA-Z_][a-zA-Z_0-9]*\.)+([a-zA-Z_][a-zA-Z_0-9]*|\*)$/
     
         /**
          * finds matching imported classes or static methods
    -     * @param prefix
    -     * @param importSpec
    -     * @param matches
    -     * @return
    +     * @param importSpec an import statement without the leading 'import ' 
or trailing semicolon
    +     * @return all names matching the importSpec
          */
    -    void collectImportedSymbols(final String importSpec, final 
Collection<String> matches) {
    +    SortedSet<String> collectImportedSymbols(final String importSpec) {
    --- End diff --
    
    While I don't think `collectImportedSymbols` was meant to be called outside 
this class there is a chance it could be since it's a public method.  So to 
avoid a breaking change and to have the chance to include this in the next 2.4 
release (2.4.8) it would be necessary to keep the `void 
collectImportedSymbols(String,Collection)` method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to