Github user jespersm commented on a diff in the pull request:
https://github.com/apache/groovy/pull/485#discussion_r98621018
--- Diff:
subprojects/groovy-parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/TryWithResourcesASTTransformation.java
---
@@ -342,7 +348,7 @@ private ExpressionStatement
createAddSuppressedStatement(String primaryExcName,
new MethodCallExpression(
new VariableExpression(primaryExcName),
"addSuppressed",
- new
ArgumentListExpression(Collections.singletonList(new
VariableExpression(suppressedExcName))));
+ new
ArgumentListExpression(Collections.singletonList((Expression) new
VariableExpression(suppressedExcName))));
--- End diff --
True! But the type inference on Java 7 needs this, or you'll get a type
mismatch, since a List<VariableExpression> is not the same as List<Expression>.
On Java 8, the type inference can solve this by itself, by checking the
supertypes of the generic argument to singletonList.
I found 5-6 of these kind of required change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
