Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/282#discussion_r107536241
--- Diff: src/main/groovy/grape/GrapeIvy.groovy ---
@@ -76,11 +76,11 @@ class GrapeIvy implements GrapeEngine {
Set<String> resolvedDependencies
Set<String> downloadedArtifacts
// weak hash map so we don't leak loaders directly
- Map<ClassLoader, Set<IvyGrabRecord>> loadedDeps = new
WeakHashMap<ClassLoader, Set<IvyGrabRecord>>()
+ final Map<ClassLoader, Set<IvyGrabRecord>> loadedDeps = new
WeakHashMap<ClassLoader, Set<IvyGrabRecord>>()
// set that stores the IvyGrabRecord(s) for all the dependencies in
each grab() call
- Set<IvyGrabRecord> grabRecordsForCurrDependencies = new
LinkedHashSet<IvyGrabRecord>()
+ final Set<IvyGrabRecord> grabRecordsForCurrDependencies = new
LinkedHashSet<IvyGrabRecord>()
// we keep the settings so that addResolver can add to the resolver
chain
- IvySettings settings
+ final IvySettings settings
--- End diff --
not sure those finals are ok, it means there will be no getter for these
anymore. So I would like to hear from for example Paul that these are not
supposed to have getter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
