[
https://issues.apache.org/jira/browse/GROOVY-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995988#comment-15995988
]
ASF GitHub Bot commented on GROOVY-8174:
----------------------------------------
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/534
GROOVY-8174: Groovy.Sql+Oracle parameter substitution problem
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8174
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #534
----
commit 0efbd83cf46678cc7dacc365634af24db0affb96
Author: paulk <[email protected]>
Date: 2017-05-04T00:53:41Z
GROOVY-8174: Groovy.Sql+Oracle parameter substitution problem
----
> Groovy.Sql+Oracle parameter substitution problem
> ------------------------------------------------
>
> Key: GROOVY-8174
> URL: https://issues.apache.org/jira/browse/GROOVY-8174
> Project: Groovy
> Issue Type: Bug
> Components: SQL processing
> Affects Versions: 2.4.11
> Environment: Java 1.8.0_131, Groovy 2.4.11, Oracle ojdbc7 12.1.0.2.0
> Reporter: Thom DeCarlo
>
> I'm using the groovy.sql libraries inside of a Java program and having
> trouble with parameter substitution. My code looks like this:
> {code}
> def mdds = Sql.newInstance(...)
> Map<String, Object>params = new HashMap<String, Object>();
> params.clear();
> params.put("source_system_id", Integer.valueOf(6));
> params.put("rec_loc_txt", "Test" + randomNum.toString());
> params.put("created_dt_tm", new
> Timestamp(System.currentTimeMillis()));
>
> String mdSqlString = "INSERT INTO MD_CATALOG " +
> " (SOURCE_SYSTEM_ID, REC_LOC_TXT,
> CREATED_DT_TM)" +
> " VALUES" +
> " (:source_system_id, :rec_loc_txt,
> :created_dt_tm)";
> try {
> List<List<Object>> keys = mdds.executeInsert(params,
> mdSqlString);
> } catch (SQLException e) {
> // TODO Auto-generated catch block
> e.printStackTrace();
> }
> {code}
> But, when it runs, I get an exception thrown that says:
> {code}
> Exception in thread "main" java.lang.IllegalArgumentException: Found 4
> parameter placeholders but supplied with 3 parameters
> at groovy.sql.Sql.setParameters(Sql.java:4116)
> at groovy.sql.Sql.getPreparedStatement(Sql.java:4394)
> at groovy.sql.Sql.executeInsert(Sql.java:2610)
> at groovy.sql.Sql.executeInsert(Sql.java:2674)
> at org.mitre.mac.Main.main(Main.java:70)
> {code}
> But, I only see 3 placeholders for my 3 parameters.
> Via email, John Wagenleitner replied:
> I did a quick test with Groovy 2.4.11 and Oracle 11.2.0.4 (ojdbc6.jar
> 11.2.0.4 and ojdbc7.jar 12.1.0.2.0) and get the same error. From what I am
> seeing Oracle changes the sql to:
> {code}INSERT INTO MD_CATALOG (SOURCE_SYSTEM_ID, REC_LOC_TXT, CREATED_DT_TM)
> VALUES (?, ?, ?) RETURNING ROWID INTO ?{code}
> adding the extra bind parameter for ROWID and this is reflected in the call
> to
> [metaData.getParameterCount()|https://github.com/apache/groovy/blob/GROOVY_2_4_11/subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java#L4115]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
