[
https://issues.apache.org/jira/browse/GROOVY-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000143#comment-16000143
]
Paul King commented on GROOVY-8177:
-----------------------------------
I added the missing source file headers, renamed the subdirectory and updated
the notice/license files.
Rat still doesn't check the files automatically. You can do a manual check by
temporarily adding `parser-antlr4` to the subprojects in `settings.gradle` and
running the `:parser-antlr4:rat` task.
The comments regarding findbugs, checkstyle, codenarc, jacoco remain unchanged.
> Remedial work still needed for groovy-parser-antlr4 subproject
> --------------------------------------------------------------
>
> Key: GROOVY-8177
> URL: https://issues.apache.org/jira/browse/GROOVY-8177
> Project: Groovy
> Issue Type: Bug
> Reporter: Paul King
>
> The groovy-parser-antlr4 folder under subprojects isn't really a project. We
> should either make it a real project or remove it. If not a module we should
> probably remove the "groovy-" prefix to its name. Different treatment may be
> needed under GROOVY_2_6_X and master.
> Because of above, rat doesn't run on any of the files in that folder. There
> are currently 205 rat violations (mostly missing license headers) that need
> to be addressed. Also, the g4 files need to be assessed so as to include any
> needed information in the NOTICE/LICENSE files.
> Also, findbugs, checkstyle, codenarc, jacoco don't run on those files under
> CI since the useAntlr4 flag isn't set. Depending on how above is resolved, we
> may need to make further changes to the CI builds.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
