Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/533#discussion_r116363767
--- Diff: src/main/org/apache/groovy/ast/tools/ClassNodeUtils.java ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.groovy.ast.tools;
+
+import org.codehaus.groovy.ast.ClassNode;
+
+public class ClassNodeUtils {
+ /**
+ * Formats a type name into a human readable version. For arrays,
appends "[]" to the formatted
+ * type name of the component. For unit class nodes, uses the class
node name.
+ *
+ * @param cNode the type to format
+ * @return a human readable version of the type name
(java.lang.String[] for example)
+ */
+ public static String formatTypeName(ClassNode cNode) {
--- End diff --
This seems like a candidate to be a package-private instance method on
`ClassNode`. Package-private part assumes the moving of the `MethodNodeUtils`
methods into `MethodNode`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
