[
https://issues.apache.org/jira/browse/GROOVY-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062307#comment-16062307
]
ASF GitHub Bot commented on GROOVY-8197:
----------------------------------------
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/564#discussion_r123887454
--- Diff:
subprojects/groovy-testng/src/test/groovy/org/codehaus/groovy/testng/TestNgRunnerTest.groovy
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.codehaus.groovy.testng
--- End diff --
should we take this opportunity to also move to org.apache package along
with the actual runner of course? It's basically an internal class but for BC
I'd leave the current runner (just extending the org.apache one) as Deprecated
in 2.5 and possibly removed in 2.6/master.
> Make JUnit3/4 GroovyRunners
> ---------------------------
>
> Key: GROOVY-8197
> URL: https://issues.apache.org/jira/browse/GROOVY-8197
> Project: Groovy
> Issue Type: Brainstorming
> Components: groovy-runtime
> Affects Versions: 2.5.0-alpha-1, 2.4.11
> Reporter: John Wagenleitner
> Priority: Minor
>
> Current {{GroovyShell}} currently has reflective methods to detect and run
> JUnit3 and JUnit4 classes. These methods might work god as {{GroovyRunner}}
> classes and they could be added to the RUNNER_REGISTRY in {{GroovySystem}}.
> Runners should be able to be registered during class loading (like most other
> things) rather than during Grape processing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
