mg created GROOVY-8344:
--------------------------

             Summary: ASTTransformationVisitor should throw early on null 
ASTTransformation entries
                 Key: GROOVY-8344
                 URL: https://issues.apache.org/jira/browse/GROOVY-8344
             Project: Groovy
          Issue Type: Bug
          Components: Compiler
    Affects Versions: 2.5.0-beta-2
            Reporter: mg
            Priority: Minor


Conditions under which the error occurs:
# ASTTransformation which does not reside in the org.codehaus.groovy.transform 
package (but instead e.g. in org.codehaus.groovy.transform.autofinal)
# ASTTransformation  implementation uses an ASTTransformationVisitor 
# => NullPointerException when the ASTTransformation is to be applied to 
ASTNode|s
in ASTTransformationVisitor#visitClass(ClassNode classNode)
{code}
// second pass, call visit on all of the collected nodes
for (ASTNode[] node : targetNodes) {
    for (ASTTransformation snt : transforms.get(node[0])) {
        // <zip>
        snt.visit(node, source); // NullPointerException
    }
}
{code}

Stacktrace:
{code}
BUG! exception in phase 'semantic analysis' in source unit 
'TestScriptnull2.groovy' unexpected NullpointerException
        at 
org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1075)
        at 
org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:613)
        at 
org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:591)
        at 
org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:568)
        at 
groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:299)
        at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:269)
        at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:255)
        at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:212)
        at groovy.lang.GroovyClassLoader$parseClass.call(Unknown Source)
        at 
gls.CompilableTestSupport.shouldNotCompile(CompilableTestSupport.groovy:27)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:483)
        at 
org.codehaus.groovy.runtime.callsite.PogoMetaMethodSite$PogoCachedMethodSiteNoUnwrapNoCoerce.invoke(PogoMetaMethodSite.java:210)
        at 
org.codehaus.groovy.runtime.callsite.PogoMetaMethodSite.callCurrent(PogoMetaMethodSite.java:59)
        at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:166)
        at 
org.codehaus.groovy.transform.AutoFinalClosureTransformTest.assertAutoFinalTestScriptWithAnnotation(AutoFinalClosureTransformTest.groovy:217)
        at 
org.codehaus.groovy.transform.AutoFinalClosureTransformTest$assertAutoFinalTestScriptWithAnnotation$0.callCurrent(Unknown
 Source)
        at 
org.codehaus.groovy.transform.AutoFinalClosureTransformTest.assertAutoFinalClassTestScript(AutoFinalClosureTransformTest.groovy:211)
        at 
org.codehaus.groovy.transform.AutoFinalClosureTransformTest$assertAutoFinalClassTestScript.callCurrent(Unknown
 Source)
        at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:52)
        at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:154)
        at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:174)
        at 
org.codehaus.groovy.transform.AutoFinalClosureTransformTest.testAutoFinalClosure(AutoFinalClosureTransformTest.groovy:177)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:483)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
        at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
        at 
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
        at 
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
        at 
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
        at 
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
Caused by: java.lang.NullPointerException
        at 
org.codehaus.groovy.transform.ASTTransformationVisitor.visitClass(ASTTransformationVisitor.java:134)
        at 
org.codehaus.groovy.transform.ASTTransformationVisitor$2.call(ASTTransformationVisitor.java:178)
        at 
org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1070)
        ... 46 more
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to