Github user paulk-asert commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/645#discussion_r158594944
  
    --- Diff: 
subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/completion/ImportsSyntaxCompletor.groovy
 ---
    @@ -105,12 +105,12 @@ class ImportsSyntaxCompletor implements 
IdentifierCompletor {
                     Class clazz = shell.interp.evaluate([className]) as Class
                     if (clazz != null) {
                         List<String> clazzSymbols = 
ReflectionCompletor.getPublicFieldsAndMethods(clazz, '')*.value
    -                    List<String> importedSymbols;
    +                    Collection<String> importedSymbols
                         if (symbolName == '*') {
    -                        importedSymbols = clazzSymbols;
    +                        importedSymbols = clazzSymbols
                         } else {
                             Set<String> acceptableMatches = [symbolName, 
symbolName + '(', symbolName + '()']
    -                        importedSymbols = 
acceptableMatches.intersect(clazzSymbols)
    +                        importedSymbols = (acceptableMatches as 
Collection).intersect(clazzSymbols)
    --- End diff --
    
    Was changing this file needed?


---

Reply via email to