[ 
https://issues.apache.org/jira/browse/GROOVY-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387691#comment-16387691
 ] 

Paul King commented on GROOVY-7624:
-----------------------------------

The proposed PR modifies the existing methods to obey their name and advertised 
behavior in the javadoc. It also adds {{asUnmodifiable()}} variants which 
provide the existing flawed behavior for those times when a view is sufficient 
and the extra copying is unwanted.

> Collection asImmutable() methods aren't immutable
> -------------------------------------------------
>
>                 Key: GROOVY-7624
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7624
>             Project: Groovy
>          Issue Type: Bug
>          Components: groovy-jdk
>    Affects Versions: 2.4.5
>            Reporter: Christopher Smith
>            Assignee: Paul King
>            Priority: Minor
>              Labels: breaking
>
> The contract for the Collection {{asImmutable()}} methods specify that the 
> returned collection is immutable, but in fact the collection is merely 
> read-only; it uses {{Collections.unmodifiable*()}}, which wraps an underlying 
> collection that is still mutable.
> These methods should return actual immutable collections, either using 
> Collections unmodifiables with copies of the underlying collections or using 
> an actual immutable backing implementation, a la Guava.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to