Github user danielsun1106 commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/686#discussion_r182659807
  
    --- Diff: 
src/main/java/org/codehaus/groovy/transform/NewifyASTTransformation.java ---
    @@ -196,39 +322,10 @@ private boolean shouldTransform(DeclarationExpression 
exp) {
         }
     
         private boolean hasClassesToNewify() {
    -        return classesToNewify != null && 
!classesToNewify.getExpressions().isEmpty();
    +        return (classesToNewify != null && 
!classesToNewify.getExpressions().isEmpty()) || (classNamePattern != null); // 
2018-04-07 TODO: Check if classNamePattern != null can be made more "early out"
    --- End diff --
    
    I see `TODO` here, are you going to refine it later?


---

Reply via email to