pzygielo commented on a change in pull request #902: GROOVY-9056: Rename method
`visit` of `ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902#discussion_r268428858
##########
File path: src/main/java/org/codehaus/groovy/ast/ASTNode.java
##########
@@ -50,8 +50,18 @@
private int lastColumnNumber = -1;
private Map metaDataMap = null;
+ public void accept(GroovyCodeVisitor visitor) {
+ throw new RuntimeException("No accept() method implemented for class:
" + getClass().getName());
+ }
+
+ /**
+ * An alias method for {@link
org.codehaus.groovy.ast.ASTNode#accept(GroovyCodeVisitor)}
+ * Note: the method will be removed in a future version, e.g. Groovy 4 or
Groovy 5
Review comment:
I was asking about `visit` method only, the one planned for removal.
Wouldn't missing method (without prior warning) be more disturbing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
