eric-milles commented on issue #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a… URL: https://github.com/apache/groovy/pull/902#issuecomment-477328705 Another problem this change will introduce: Any class that extends one of the `ASTNode` subclasses and intends to override the behavior of a parent's `visit` or even call to the parent's `visit` could be getting something unexpected. Would a call `super.visit(visitor)` reliably map to the parent's `accept` method? And if any class already has a method `accept(GroovyCodeVisitor)`, it will suddenly be an override. (Probably less likely, but a consideration to make.)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
