paulk-asert commented on issue #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a… URL: https://github.com/apache/groovy/pull/902#issuecomment-477335342 Eric makes some good points. Maybe making this change is more trouble than it is worth. The visit/accept names are after all just a convention. Some languages use dispatch instead of visit by convention for instance. I agree that using visit/visit as our convention is probably unique if not a little strange but most of us have become familiar with it. An alternative might be to just rename the parameter from visitor -> acceptedVisitor. And perhaps add some Groovydoc: "... accepts a visitor .." or similar.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
