blackdrag commented on issue #990: GROOVY-9223: Avoid generating common methods 
for each groovy class
URL: https://github.com/apache/groovy/pull/990#issuecomment-521622589
 
 
   I am actually a bit surprised there has been no problem with the meta class 
invocation logic here, because I remember this being a little bit fragile... To 
be specific, if you had a call on a GroovyObject using invokeMethod that does 
not exist, then the meta class logic for the fallback to invokeMethod was 
sometimes triggered leading to an endless loop. I think we reliably solved that 
back then, but I don't remember where this logic was (maybe in the callsite 
stuff and/or the bytecode interface) exactly. But if all tests pass I guess it 
is ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to