danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary 
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
 
 
   As `resolveFromStaticInnerClasses` only resolves classes whose name contains 
`.` and `resolveToOuter` only resolves classes whose name does not contains 
`.`, no overlap in their target classes to resolve, thus no breaking changes in 
the PR IMO. (See the comment in the following code)
   
   
https://github.com/apache/groovy/blob/79dfd8586b33e3c80add6b2ffb26c07ff7a6e8b3/src/main/java/org/codehaus/groovy/control/ResolveVisitor.java#L552-L558
   
   
https://github.com/apache/groovy/blob/79dfd8586b33e3c80add6b2ffb26c07ff7a6e8b3/src/main/java/org/codehaus/groovy/control/ResolveVisitor.java#L845-L856
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to