[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919797#comment-16919797
]
Daniel Sun commented on GROOVY-9236:
------------------------------------
Here is the difference of classes to guess:
* After changes:
{code:java}
groovy.lang.GroovyObject$java$util$stream$Collectors
groovy.lang.GroovyObject$groovy$transform$CompileStatic
groovy.lang.GroovyObject$java$util$stream$Stream
groovy.lang.GroovyObject$CompileStatic
groovy.lang.GroovyObject$Collectors
Script1BeanInfo
Script1Customizer
Script1$_p_lambda1BeanInfo
Script1$_p_lambda1Customizer
{code}
* Before changes:
{code:java}
Script1$_p_lambda1BeanInfo
Script1$_p_lambda1Customizer
Script1BeanInfo
Script1Customizer
groovy$transform$CompileStatic
groovy.lang.GroovyObject$Collectors
groovy.lang.GroovyObject$CompileStatic
groovy.lang.GroovyObject$groovy$transform$CompileStatic
groovy.lang.GroovyObject$java$util$stream$Collectors
groovy.lang.GroovyObject$java$util$stream$Stream
groovy.lang.groovy$transform$CompileStatic
groovy.lang.java$util$stream$Collectors
groovy.lang.java$util$stream$Stream
groovy.transform$CompileStatic
groovy.util.groovy$transform$CompileStatic
groovy.util.java$util$stream$Collectors
groovy.util.java$util$stream$Stream
java$util$stream$Collectors
java$util$stream$Stream
java.io.groovy$transform$CompileStatic
java.io.java$util$stream$Collectors
java.io.java$util$stream$Stream
java.lang.groovy$transform$CompileStatic
java.lang.java$util$stream$Collectors
java.lang.java$util$stream$Stream
java.net.groovy$transform$CompileStatic
java.net.java$util$stream$Collectors
java.net.java$util$stream$Stream
java.util$stream$Collectors
java.util$stream$Stream
java.util.groovy$transform$CompileStatic
java.util.java$util$stream$Collectors
java.util.java$util$stream$Stream
java.util.stream$Collectors
java.util.stream$Stream
{code}
( [https://github.com/apache/groovy/pull/998#issuecomment-526408884] )
> Avoid unnecessary resolving
> ---------------------------
>
> Key: GROOVY-9236
> URL: https://issues.apache.org/jira/browse/GROOVY-9236
> Project: Groovy
> Issue Type: Improvement
> Reporter: Daniel Sun
> Assignee: Daniel Sun
> Priority: Major
> Fix For: 3.0.0-beta-4
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {{ResolveVisitor}}'s {{resolveFromStaticInnerClasses}},
> {{resolveFromDefaultImports}} and {{resolveNestedClass}} will try to guess
> class qualified name and load. In the process of resolving, lots of time
> wasted on finding non-existing classes. So we should try to resolve classes
> in a determined manner.
> For example,
> For {{java.util.stream.Collectors}}, ① {{resolveFromStaticInnerClasses}}
> will try to guess {{java.util.stream$Collectors}},
> {{java.util$stream$Collectors}}, {{java$util$stream$Collectors}}.
> And ② {{resolveFromDefaultImports}} will guess
> {{java.lang.java$util$stream$Collectors}},
> {{java.util.java$util$stream$Collectors}}, ...,
> {{groovy.lang.java$util$stream$Collectors}}.
> After the precedence of resolving adjusted, the above unnecessary resolving
> can be avoided.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
