eric-milles commented on issue #1085: GROOVY-9175 migrate private methods to 
protected
URL: https://github.com/apache/groovy/pull/1085#issuecomment-554522795
 
 
   What I mean is this: SecureASTCustomizer is a class that extends 
CompilationCustomizer.  If there are some select parts of SecureASTCustomizer 
that you wish to share, then move them into an abstract class that sits between 
SecureASTCustomizer and CompilationCustomizer or into an interface that 
SecureASTCustomizer implements.
   
   By opening **all** the parts of SecureASTCustomizer to extension, you are 
completely removing the ability to enhance or refactor SecureASTCustomizer 
without the possibility of impacting extensions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to