danielsun1106 commented on issue #1135: GROOVY-8298: Slow Performance Caused by 
Invoke Dynamic
URL: https://github.com/apache/groovy/pull/1135#issuecomment-570900509
 
 
   Jochen, as you found, the regular case the most inefficient one. So in the 
latest commit I introduce a threshold to control whether to set target.
   ```groovy
   def m(i){1}
   for (int i = 0; i < 100_000_000; i++) {
    if (m(i)!=1) throw new Error("??")
   }
   ```
   (indy2: before commit 6092c76: **15s**, after commit 6092c76(threshold: 
100_000): **3s**, indy1: **3s**. indy2 costs almost same time to indy1 on my 
machine)
   
   Please review the PR again, thanks :-)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to