[
https://issues.apache.org/jira/browse/GROOVY-9599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141625#comment-17141625
]
Remko Popma commented on GROOVY-9599:
-------------------------------------
Fix and additional test committed to the
[master|https://github.com/apache/groovy/commit/16a5c42e53c440d3675d7b7cb91113a584663b86],
[GROOVY_3_0_X|https://github.com/apache/groovy/commit/829b19c7bcc91b3aa80f16379f980dc5dcdf9c64]
and
[GROOVY_2_5_X|https://github.com/apache/groovy/commit/ede7ffca2bf151471cfc888ee41d4c4f68d3d906]
branches.
Test results look good in [CI|https://groovy.apache.org/buildstatus.html]
([master|https://ci.groovy-lang.org/viewLog.html?buildId=2154&buildTypeId=MasterTestJdk8],
[3.0|https://ci.groovy-lang.org/viewLog.html?buildId=2151&buildTypeId=Groovy30xTestAllJdk8],
[2.5|https://ci.groovy-lang.org/viewLog.html?buildId=2159&buildTypeId=Groovy25xCheckJdk8])
Resolving this ticket as fixed.
> CliBuilder: Option with "type: String, defaultValue ''" (empty String)
> results in NullObject if default value is applied
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-9599
> URL: https://issues.apache.org/jira/browse/GROOVY-9599
> Project: Groovy
> Issue Type: Bug
> Components: command line processing
> Affects Versions: 2.5.11, 3.0.4
> Reporter: Remko Popma
> Assignee: Remko Popma
> Priority: Major
> Fix For: 3.0.5, 2.5.13
>
>
> This is a follow-up ticket for GROOVY-9519:
> After checking with Groovy 3.0.4, it seems that only the "Integer with
> defaultValue '0'" case was fixed, but not "String with defaultValue ''". The
> latter became even worse. It still ignores the defaultValue, but instead of
> creating a Boolean, it now creates a NullObject. Try this code:
> {code:java}
> @Grab('info.picocli:picocli-groovy:4.3.2')
> @GrabConfig(systemClassLoader=true)
> import groovy.cli.picocli.CliBuilder
> def cli = new CliBuilder(name: 'cliTest.groovy', stopAtNonOption: false)
> cli.h(type: Boolean, longOpt: 'help', usageHelp: true, required: false, 'Show
> usage information')
> cli.a(type: String, longOpt: 'optA', required: false, args: 1, defaultValue:
> '', 'Option a (optional)')
> def opts = cli.parse(args)
> opts || System.exit(1)
> if(opts.h) {
> cli.usage()
> System.exit(0)
> }
> println(opts.a.getClass())
> if (opts.a) {
> println(opts.a)
> }
> {code}
> with Groovy 3.0.2:
> {code:java}
> % ~/tmp/groovy-3.0.2/bin/groovy ./cliTest.groovy
> class java.lang.Boolean
> {code}
> and with Groovy 3.0.4:
> {code:java}
> % ~/tmp/groovy-3.0.4/bin/groovy ./cliTest.groovy
> class org.codehaus.groovy.runtime.NullObject
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
