paulk-asert commented on pull request #1342: URL: https://github.com/apache/groovy/pull/1342#issuecomment-670772378
We could probably do the `-Dgroovy.macro.disable=foo,bar` variant. We want something that is going to be fast, so I'd avoid Patterns. A compiler configuration option isn't enough - it doesn't cover dynamic Groovy and I think it might be a little messy trying to block off access to extensions/macros once they are in our caches. Good news though for @CompileStatic code is that you only need the switch during compilation. We could get fancier trying to disable particular variants of extensions/macros but I felt YAGNI calling. I imagine disabling would mostly be for folks already using methods with those names when new macros are introduced. They'd just want to block all variants and perhaps consider refactoring and removing the disable switch later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
