[ 
https://issues.apache.org/jira/browse/GROOVY-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186144#comment-17186144
 ] 

Paul King commented on GROOVY-9702:
-----------------------------------

Merged for Groovy 4. [~emilles] Would something like 
https://github.com/apache/groovy/pull/1356 work for GROOVY_3_0_X (and 
potentially GROOVY_2_5_X). I agree that runtime seems unlikely to be needed but 
just exploring whether we can avoid the breaking change on a point release.

> ASTTest annotation has runtime retention and transform removes required 
> member from AST
> ---------------------------------------------------------------------------------------
>
>                 Key: GROOVY-9702
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9702
>             Project: Groovy
>          Issue Type: Bug
>            Reporter: Eric Milles
>            Assignee: Eric Milles
>            Priority: Major
>              Labels: breaking
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Consider the following:
> {code:groovy}
> import groovy.transform.*
> import org.codehaus.groovy.ast.*
> import static org.codehaus.groovy.transform.stc.StaticTypesMarker.*
> class C {
>   void m() {
>     def that = this;
>     { ->
>       @ASTTest(phase=INSTRUCTION_SELECTION, value={
>         ClassNode type = node.getNodeMetaData(INFERRED_TYPE)
>         assert type?.name == 'C'
>       })
>       def ref = getThisObject()
>       assert ref == that
>     }()
>   }
> }
> {code}
> This is a typical use of {{@ASTTest}}.  When compiled, the test annotation is 
> retained in the class file, which is unnecessary.  When the transform class 
> runs, it removes the "value" member from the AST, which is causing compiler 
> errors down the line when {{ExtendedVerifier}} runs {{AnnotationVisitor}}.  
> Also, the variable scope of the test closure is still connected to the class 
> and module, so code completion is making proposals for class members which 
> will not be there at run-time.
> This was originally investigated from the IDE side (see linked issue).
> [https://user-images.githubusercontent.com/18193802/90964420-fd51c800-e485-11ea-8349-c0f89e04561a.png]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to