nescohen commented on a change in pull request #1392:
URL: https://github.com/apache/groovy/pull/1392#discussion_r499004203
##########
File path:
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
##########
@@ -2592,7 +2592,7 @@ public void visitStaticMethodCallExpression(final
StaticMethodCallExpression cal
// in that order
List<Receiver<String>> receivers = new LinkedList<>();
addReceivers(receivers, makeOwnerList(new
ClassExpression(receiver)), false);
- List<MethodNode> mn = null;
+ List<MethodNode> mn = Collections.emptyList();
Receiver<String> chosenReceiver = null;
for (Receiver<String> currentReceiver : receivers) {
mn = findMethod(currentReceiver.getType(), name, args);
Review comment:
Good point @paulk-asert. I think a null check would also be a reasonable
solution.
The one nice thing about using Collections.emtpyList() though is that no new
list is allocated. It's simply a statically defined, immutable empty list. See
https://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#emptyList()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
