melix commented on a change in pull request #1382:
URL: https://github.com/apache/groovy/pull/1382#discussion_r499256703
##########
File path:
buildSrc/src/main/groovy/org/apache/groovy/gradle/GroovyLibraryExtension.groovy
##########
@@ -64,16 +66,18 @@ class GroovyLibraryExtension {
final TaskContainer tasks
final ProjectLayout layout
+ @Inject
GroovyLibraryExtension(ObjectFactory factory,
+ ProjectLayout layout,
SharedConfiguration sharedConfiguration,
JavaPluginConvention javaPluginConvention,
JavaPluginExtension javaPluginExtension,
SoftwareComponentContainer components,
ConfigurationContainer configurations,
- TaskContainer tasks,
- ProjectLayout layout
+ TaskContainer tasks
) {
this.objects = factory
+ this.layout = layout
this.sharedConfiguration = sharedConfiguration
this.includeInGroovyAll = factory.property(Boolean).convention(true)
this.grooid = factory.property(Boolean).convention(false)
Review comment:
I could but given that I need to inject other properties in any case, I
prefer keeping the things consistent and not have a mix of abstract properties
and injected properties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
