[
https://issues.apache.org/jira/browse/GROOVY-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King updated GROOVY-9774:
------------------------------
Description:
The various build scripts and associated artifacts have been written by
numerous folks targeting numerous versions of Gradle over many years. The
styles have drifted apart and some places use very old conventions/style. We
should consolidate/update as needed.
*Cloned* to track some differences in test results. We aren't necessarily
attempting to get like for like - perhaps some tests weren't running correctly
previously - we should at least understand differences.
These are sporadic - e.g. aren't happening on the CI server right now. We are
changing global config for grapes, e.g.
https://github.com/apache/groovy/blob/master/src/test/groovy/grape/GrapeIvyTest.groovy#L298
Perhaps we need to isolate that test better.
Some Grape tests (package groovy.grape) run differently. Old:
!screenshot-1.png!
New ({{testAutoDownloadGrapeConfig}} was split in three to better isolate the
failure):
!screenshot-2.png!
Related failure in {{groovy.bugs.Groovy8060Bug}}. Old:
!screenshot-3.png!
New:
!screenshot-4.png!
With stacktrace (shown for Windows):
{noformat}
BUG! exception in phase 'conversion' in source unit 'TestScript10.groovy' null
...
at
groovy.bugs.Groovy8060Bug.testLoggingWithinClosuresThatAreMethodArgsShouldHaveGuards(Groovy8060Bug.groovy:25)
...
Caused by: java.nio.file.NoSuchFileException:
D:\projects\groovy\build\tmp\test\grape\grapes\org.slf4j\slf4j-simple\jars\slf4j-simple-1.7.25.jar
...
at groovy.grape.GrapeIvy.grab(GrapeIvy.groovy:264)
{noformat}
Jar does appear to be there after the build and test passes in isolation.
groovy.bugs.Groovy6932Bug also fails sporadically but runs in isolation:
{noformat}
General error during conversion: Error grabbing Grapes -- [download failed:
org.slf4j#slf4j-simple;1.7.25!slf4j-simple.jar]
...
at
groovy.bugs.Groovy6932Bug.testLoggingWithinClosuresShouldHaveGuards(Groovy6932Bug.groovy:25)
{noformat}
was:
The various build scripts and associated artifacts have been written by
numerous folks targeting numerous versions of Gradle over many years. The
styles have drifted apart and some places use very old conventions/style. We
should consolidate/update as needed.
*Cloned* to track some differences in test results. We aren't necessarily
attempting to get like for like - perhaps some tests weren't running correctly
previously - we should at least understand differences.
These are sporadic - e.g. aren't happening on the CI server right now. We are
changing global config for grapes, e.g.
https://github.com/apache/groovy/blob/master/src/test/groovy/grape/GrapeIvyTest.groovy#L298
Perhaps we need to isolate that test better.
Some Grape tests (package groovy.grape) run differently. Old:
!screenshot-1.png!
New ({{testAutoDownloadGrapeConfig}} was split in three to better isolate the
failure):
!screenshot-2.png!
Related failure in {{groovy.bugs.Groovy8060Bug}}. Old:
!screenshot-3.png!
New:
!screenshot-4.png!
With stacktrace (shown for Windows):
{noformat}
BUG! exception in phase 'conversion' in source unit 'TestScript10.groovy' null
...
Caused by: java.nio.file.NoSuchFileException:
D:\projects\groovy\build\tmp\test\grape\grapes\org.slf4j\slf4j-simple\jars\slf4j-simple-1.7.25.jar
...
at groovy.grape.GrapeIvy.grab(GrapeIvy.groovy:264)
{noformat}
Jar does appear to be there after the build.
> Rework gradle build to use modern conventions - test remediation
> ----------------------------------------------------------------
>
> Key: GROOVY-9774
> URL: https://issues.apache.org/jira/browse/GROOVY-9774
> Project: Groovy
> Issue Type: Task
> Reporter: Paul King
> Assignee: Cédric Champeau
> Priority: Major
> Fix For: 4.0.0-alpha-2
>
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png
>
>
> The various build scripts and associated artifacts have been written by
> numerous folks targeting numerous versions of Gradle over many years. The
> styles have drifted apart and some places use very old conventions/style. We
> should consolidate/update as needed.
> *Cloned* to track some differences in test results. We aren't necessarily
> attempting to get like for like - perhaps some tests weren't running
> correctly previously - we should at least understand differences.
> These are sporadic - e.g. aren't happening on the CI server right now. We are
> changing global config for grapes, e.g.
> https://github.com/apache/groovy/blob/master/src/test/groovy/grape/GrapeIvyTest.groovy#L298
> Perhaps we need to isolate that test better.
> Some Grape tests (package groovy.grape) run differently. Old:
> !screenshot-1.png!
> New ({{testAutoDownloadGrapeConfig}} was split in three to better isolate the
> failure):
> !screenshot-2.png!
> Related failure in {{groovy.bugs.Groovy8060Bug}}. Old:
> !screenshot-3.png!
> New:
> !screenshot-4.png!
> With stacktrace (shown for Windows):
> {noformat}
> BUG! exception in phase 'conversion' in source unit 'TestScript10.groovy' null
> ...
> at
> groovy.bugs.Groovy8060Bug.testLoggingWithinClosuresThatAreMethodArgsShouldHaveGuards(Groovy8060Bug.groovy:25)
> ...
> Caused by: java.nio.file.NoSuchFileException:
> D:\projects\groovy\build\tmp\test\grape\grapes\org.slf4j\slf4j-simple\jars\slf4j-simple-1.7.25.jar
> ...
> at groovy.grape.GrapeIvy.grab(GrapeIvy.groovy:264)
> {noformat}
> Jar does appear to be there after the build and test passes in isolation.
> groovy.bugs.Groovy6932Bug also fails sporadically but runs in isolation:
> {noformat}
> General error during conversion: Error grabbing Grapes -- [download failed:
> org.slf4j#slf4j-simple;1.7.25!slf4j-simple.jar]
> ...
> at
> groovy.bugs.Groovy6932Bug.testLoggingWithinClosuresShouldHaveGuards(Groovy6932Bug.groovy:25)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
