[ 
https://issues.apache.org/jira/browse/GROOVY-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246673#comment-17246673
 ] 

André Filipe Aloise commented on GROOVY-9852:
---------------------------------------------

I confirm that {code:java} assert p.future() === p.future().onSuccess({ println 
it } as io.vertx.core.Handler){code} is a valid workaround for Vert.x 4.0.0 GA 
with Groovy 3.0.7.

If parentheses are removed from onSuccess method, then IllegalStateException 
also gets thrown 
{code:java}
assert p.future() === p.future().onSuccess{ println it } as 
io.vertx.core.Handler{code}

The workaround provided wasn't necessary, and IllegalStateException didn't 
happen, until version 4.0.0.Beta1 of Vert.x, which was using Groovy 3.0.3. I 
noticed that version 4.0.0.Beta2 of Vert.x, that uses Groovy 3.0.5, started to 
manifest this symptoms.

Besides that, if you use any version of Vert.x 3.9.x, like 3.9.5-SNAPSHOT for 
instance, which uses Groovy 3.0.7, the IllegalStateException doesn't get 
thrown. The workaround isn't needed too.

Has anything changed since version 3.0.4 or 3.0.5 that may have caused this?

> Result is already complete (IllegalStateException)
> --------------------------------------------------
>
>                 Key: GROOVY-9852
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9852
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 3.0.5
>         Environment: Windows 10
> OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_272-b10)
>            Reporter: André Filipe Aloise
>            Assignee: Eric Milles
>            Priority: Major
>
> Steps:
> 1 - Consider this reproducer [https://github.com/ptomaszek/vertx-groovy]
> 2 - Edit build.gradle and change vertxVersion to '4.0.0.Beta1' (uses Groovy 
> 3.0.3)
> 3 - Edit org.example.MainGroovy and replace the code of main method with the 
> following:
> {code:java}
> Promise p = Promise.promise()
> p.future().onSuccess { println it }
> p.complete("Done with Groovy!!!"){code}
> The code runs fine.
> But, if in Step 2 the vertxVersion in build.gradle is changed to 
> '4.0.0.Beta2' (uses Groovy 3.0.5), the code from Step 3 will fail with an 
> IllegalStateException. 
> {code:java}
> Exception in thread "main" java.lang.IllegalStateException: Result is already 
> complete
>  at io.vertx.core.Promise.complete(Promise.java:67)
>  at io.vertx.core.Promise$complete$1.call(Unknown Source)
>  at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:139)
>  at org.example.MainGroovy.main(MainGroovy.groovy:17)
> {code}
> If you use @CompileStatic on main method with Step 3, with Beta2, it works 
> fine. The @CompileStatic is not necessary to run well with Vert.x 
> '4.0.0.Beta1'. A Java class with similar code will work using any version of 
> Vert.x (Beta1, Beta2, Beta3, CR1....), so doesn't looks like a Java or Vertx 
> issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to