[
https://issues.apache.org/jira/browse/GROOVY-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255444#comment-17255444
]
Paul King commented on GROOVY-9852:
-----------------------------------
The fix also broke an existing test (confirmed with \{{git bisect}}), but the
test was accidentally disabled due to a build misconfiguration:
[https://github.com/apache/groovy/blob/master/subprojects/groovy-xml/src/test/groovy/groovy/xml/XmlSlurperTest.groovy#L93-L94]
The build configuration has been fixed but I had to comment out the test
temporarily. The test represents functionality that has worked for a long time
across XmlSlurper, XmlParser and DOMCategory. It currently is broken just for
XmlSlurper after this change. I'll dive in and look at possibilities when I get
a chance but might not be for a couple of days or more.
> Result is already complete (IllegalStateException)
> --------------------------------------------------
>
> Key: GROOVY-9852
> URL: https://issues.apache.org/jira/browse/GROOVY-9852
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 3.0.5
> Environment: Windows 10
> OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_272-b10)
> Reporter: André Filipe Aloise
> Assignee: Eric Milles
> Priority: Major
> Labels: Breaking-Change, breaking, breaking_change
> Fix For: 4.0.0-alpha-3
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Steps:
> 1 - Consider this reproducer [https://github.com/ptomaszek/vertx-groovy]
> 2 - Edit build.gradle and change vertxVersion to '4.0.0.Beta1' (uses Groovy
> 3.0.3)
> 3 - Edit org.example.MainGroovy and replace the code of main method with the
> following:
> {code:java}
> Promise p = Promise.promise()
> p.future().onSuccess { println it }
> p.complete("Done with Groovy!!!"){code}
> The code runs fine.
> But, if in Step 2 the vertxVersion in build.gradle is changed to
> '4.0.0.Beta2' (uses Groovy 3.0.5), the code from Step 3 will fail with an
> IllegalStateException.
> {code:java}
> Exception in thread "main" java.lang.IllegalStateException: Result is already
> complete
> at io.vertx.core.Promise.complete(Promise.java:67)
> at io.vertx.core.Promise$complete$1.call(Unknown Source)
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:139)
> at org.example.MainGroovy.main(MainGroovy.groovy:17)
> {code}
> If you use @CompileStatic on main method with Step 3, with Beta2, it works
> fine. The @CompileStatic is not necessary to run well with Vert.x
> '4.0.0.Beta1'. A Java class with similar code will work using any version of
> Vert.x (Beta1, Beta2, Beta3, CR1....), so doesn't looks like a Java or Vertx
> issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
