eric-milles commented on a change in pull request #1556:
URL: https://github.com/apache/groovy/pull/1556#discussion_r611851276



##########
File path: src/main/java/org/codehaus/groovy/classgen/asm/OperandStack.java
##########
@@ -338,6 +338,12 @@ private void doConvertAndCast(ClassNode targetType, final 
boolean coerce) {
             return;
         }
 
+        // GROOVY-10034: no need to cast non-primitive array when target is 
"java.lang.Object[]"

Review comment:
       `getTypeClass()` is a known unsafe method to use.  I would caution 
against that without thorough testing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to