eric-milles edited a comment on pull request #1661: URL: https://github.com/apache/groovy/pull/1661#issuecomment-987998605
Such as what? If you gave some examples, I might be able to provide reasoning. The purpose of the draft was to discuss these items rather than just be dismissive. What is the concern with leveraging `TraceClassVisitor` which is provided instead of maintaining `LoggableClassVisitor` which tries to do the same job and I've found many problems with the flushing and the multiple instance creation? If you are referencing the replacement of `isPostJDK5()`, then my raised concerns earlier are that "is post" is not the correct semantic. It is really "is at least" and the use if `isAtLeast(targetBytecode,JDK5)` is conveys that semantic and does not require a new public API method for every Java release, which are coming every 6 months now, not every few years. Again, this is demonstrated for discussion purposes. It is not a must have. I disagree with lifting one-time use values up to the top of a class file. I disagree with adding public API for something that *might* be useful but has no track record of need. These are specific examples that can foster further discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
