paulk-asert commented on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1041493348


   I am still looking at the changes. Some effort was put into making 
primitives behave in an "expected" way but whether we are consistent to what 
happens elsewhere needs further investigation. I am wondering whether it would 
be better to adapt `StaticTypeCheckingVisitor` to know about the individual 
`NamedParam` annotations not just the collector. The annotation collector is 
already currently applied but not until classgen phase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to