paulk-asert edited a comment on pull request #1687: URL: https://github.com/apache/groovy/pull/1687#issuecomment-1044455780
I am in favor of removing the truthy and null-handling aspect. I think the intention was just to handle the null case but I think we shouldn't even handle that - instead some judicial `IllegalArgumentException`s might be in order - whenever null is provided for a primitive or for the namedArgs map. We could always add a `nullSafePrimitive` flag to `NamedVariant` and/or `MapConstructor` which could instead provide some default instead of an `IllegalArgumentException`, but I suggest we don't do that for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
