[
https://issues.apache.org/jira/browse/GROOVY-9472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508266#comment-17508266
]
Daniil Ovchinnikov commented on GROOVY-9472:
--------------------------------------------
> it is supposed to somehow guess that some of those class files are really
> source units that should be added to the compilation unit and compiled as well
Exactly the opposite. The compiler should not care about whether a dependency
comes from another source unit or a library or an arbitrary class on the
classpath.
> Why not just send in both source units in the first place if that is what you
>expect?
Because the compilation will not be incremental if all files are recompiled
each time.
> running resolve and transforms multiple times
Not multiple times, but in multiple steps. If a reference gets resolved at some
step, it stays resolved to this exact entity in all subsequent steps. The
transforms should only be run once (or in multiple steps).
> Transforms can be assigned to any phase.
Just as before, a transform is run once during requested phase, and that's it,
no phase re-running. I've thought we are discussing how to deal with transforms
running in SEMANTIC_ANALYSIS.
> Static import causes unresolved reference to become resolved
> ------------------------------------------------------------
>
> Key: GROOVY-9472
> URL: https://issues.apache.org/jira/browse/GROOVY-9472
> Project: Groovy
> Issue Type: Bug
> Components: Compiler, Static Type Checker
> Affects Versions: 2.5.10
> Reporter: Daniil Ovchinnikov
> Assignee: Eric Milles
> Priority: Major
> Fix For: 4.0.0
>
>
> {code:groovy|title=com/foo/Person.groovy}
> package com.foo
> @groovy.transform.builder.Builder
> class Person {
> String name
> }
> {code}
> 1.
> {code:groovy|title=Main.groovy}
> import com.foo.Person
> class Main {
> static void main(String[] args) {
> Person.PersonBuilder pb = Person.builder()
> println(pb.build())
> }
> }
> {code}
> Trying to use it without a static import yields {{unable to resolve class
> Person.PersonBuilder}}, which is another issue.
> 2. Let's add a static import
> {code:groovy|title=Main.groovy}
> import com.foo.Person
> import static com.foo.Person.PersonBuilder
> class Main {
> static void main(String[] args) {
> PersonBuilder pb = Person.builder()
> println(pb.build())
> }
> }
> {code}
> The code compiles, but fails with {{java.lang.NoClassDefFoundError:
> PersonBuilder}} when run.
> 3. Let's add {{@CompileStatic}}
> {code:groovy|title=Main.groovy}
> import com.foo.Person
> import static com.foo.Person.PersonBuilder
> import groovy.transform.CompileStatic
> @CompileStatic
> class Main {
> static void main(String[] args) {
> PersonBuilder pb = Person.builder()
> println(pb.build())
> }
> }
> {code}
> Compilation fails with:
> {{Cannot assign value of type com.foo.Person$PersonBuilder to variable of
> type PersonBuilder}} and {{Cannot find matching method PersonBuilder#build()}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
