[
https://issues.apache.org/jira/browse/GROOVY-10730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17586133#comment-17586133
]
ASF GitHub Bot commented on GROOVY-10730:
-----------------------------------------
paulk-asert commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956653365
##########
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##########
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offending code/tests are
fixed
+//
https://docs.gradle.org/7.5/userguide/upgrading_version_7.html#removes_implicit_add_opens_for_test_workers
tasks.withType(Test).configureEach {
def fs = objects.newInstance(TestServices).fileSystemOperations
def grapeDirectory = new File(temporaryDir, "grape")
def jdk8 = ['-XX:+UseConcMarkSweepGC']
def jdk9 = ['-Djava.locale.providers=COMPAT,SPI']
// def jdk9 = ['-Djava.locale.providers=COMPAT,SPI',
'--illegal-access=debug']
+ if (JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_16)) {
+ jdk9 += ["--add-opens=java.base/java.lang=ALL-UNNAMED",
+ "--add-opens=java.base/java.util=ALL-UNNAMED"]
Review Comment:
The old version of gradle always added those two add-opens implicitly for
test workers:
https://docs.gradle.org/7.5/userguide/upgrading_version_7.html#removes_implicit_add_opens_for_test_workers
> Bump Gradle to 7.5.1 (build dependency)
> ---------------------------------------
>
> Key: GROOVY-10730
> URL: https://issues.apache.org/jira/browse/GROOVY-10730
> Project: Groovy
> Issue Type: Dependency upgrade
> Reporter: Paul King
> Assignee: Paul King
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
