[
https://issues.apache.org/jira/browse/GROOVY-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609985#comment-17609985
]
ASF GitHub Bot commented on GROOVY-10682:
-----------------------------------------
Shadow-Devil commented on code in PR #1785:
URL: https://github.com/apache/groovy/pull/1785#discussion_r981093151
##########
src/test/groovy/transform/stc/DefaultGroovyMethodsSTCTest.groovy:
##########
@@ -37,6 +37,20 @@ class DefaultGroovyMethodsSTCTest extends
StaticTypeCheckingTestCase {
println it // DGM#println(Object,Object)
}
'''
+
+ assertScript '''
+ int[] nums = [0, 1]
+ nums.each { it -> // ArrayGroovyMethods#each(int[], Closure)
+ println it.toDouble() // DGM#println(Object,Object)
Review Comment:
I think I would stop writing tests in this test class and only use the tests
inside the Javadoc since otherwise the number of tests would explode for ~60
methods with each 8 primitive types (roundabout 480 tests).
> Provide eachWithIndex for primitive arrays
> ------------------------------------------
>
> Key: GROOVY-10682
> URL: https://issues.apache.org/jira/browse/GROOVY-10682
> Project: Groovy
> Issue Type: Improvement
> Components: groovy-jdk
> Reporter: Eric Milles
> Assignee: Eric Milles
> Priority: Minor
>
> Consider the following:
> {code:groovy}
> @groovy.transform.TypeChecked
> void test(int[] ints) {
> ints.eachWithIndex { value, index ->
> println "$index: ${value.doubleValue()}"
> }
> }
> test(0,1,2,3,4,5)
> {code}
> Compiler reports "[Static type checking] - Cannot find matching method
> java.lang.Object#doubleValue()"
> {{eachWithIndex}} is only provided for reference types, so "value" is seen as
> Object by the type checker.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)