jonnybot0 opened a new pull request, #1814: URL: https://github.com/apache/groovy/pull/1814
Helpful background may be found in the comments of https://issues.apache.org/jira/browse/GROOVY-9541. As @eric-milles noted there, we may need to do a more careful consideration of each consumer of `StaticTypeCheckingSupport#evaluateExpression`, since the `source` object's classloader may not actually be correct in every case. I can attest that letting `org.codehaus.groovy.transform.ASTTransformationCollectorCodeVisitor#findCollectedAnnotations` use the context classloader will result in difficult-to-resolve cases of GROOVY-9541. A word about 4616fc8: without that, you'll get a [cast_failure](https://github.com/apache/groovy/files/9864104/cast_failure.txt) when trying to compile the groovy-macro module. I was a bit nervous about it, but I think `java.util.Optional#map` provides enough null safety that it should work. My local test suite is still finishing execution, but I thought a concrete diff & a PR would be helpful for the discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
