[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1816: Bugfix/groovy 9541 stc take classloader param

Sun, 06 Nov 2022 08:31:45 -0800 


sonatype-lift[bot] commented on code in PR #1816:
URL: https://github.com/apache/groovy/pull/1816#discussion_r1014858643


##########
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java:
##########
@@ -2181,6 +2182,14 @@ public static boolean missesGenericsTypes(ClassNode cn) {
         return cnGenerics == null || cnGenerics.length == 0 ? rnGenerics != 
null : GenericsUtils.hasUnresolvedGenerics(cn);
     }
 
+    /**
+     * @deprecated Use {@link #evaluateExpression(Expression, 
CompilerConfiguration, GroovyClassLoader)} instead
+     */
+    @Deprecated
+    public static Object evaluateExpression(final Expression expr, final 
CompilerConfiguration config) {

Review Comment:
   *[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):* 
 This deprecated API looks inlineable. If you'd like the body of the API to be 
inlined to its callers, please annotate it with @InlineMe.
   
   ---
   
   
   ```suggestion
       @InlineMe(replacement = 
"StaticTypeCheckingSupport.evaluateExpression(expr, config, null)", imports = 
"org.codehaus.groovy.transform.stc.StaticTypeCheckingSupport")
   ```
   
   
   
   ---
   
   <details><summary><b>ℹī¸ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=351125067&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=351125067&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=351125067&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=351125067&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=351125067&lift_comment_rating=5)
 ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to