[
https://issues.apache.org/jira/browse/GROOVY-10918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689394#comment-17689394
]
Eric Milles commented on GROOVY-10918:
--------------------------------------
I would guess that javac handles variable assignment without a temporary. For
groovyc, a left side variable expression could refer to a dynamic variable,
local variable, field, setter method or something dynamic. In order to deal
with all this, classgen tries to provide a unified approach for multiple
options.
https://github.com/apache/groovy/blob/master/src/main/java/org/codehaus/groovy/classgen/asm/BinaryExpressionHelper.java#L380
I do think I can skip the temp when the target is a local variable (like a
parameter in this case). I'm trying that out right now.
> Memory leak: local variable values are not discarded
> ----------------------------------------------------
>
> Key: GROOVY-10918
> URL: https://issues.apache.org/jira/browse/GROOVY-10918
> Project: Groovy
> Issue Type: Bug
> Components: groovy-runtime
> Affects Versions: 4.0.9
> Reporter: Andriy Rysin
> Priority: Major
> Labels: MemoryLeak
> Attachments: TestOOM.groovy, TestOOMIcj.java, TestOOMJ.java,
> TestOOM_works.groovy, groovy_oom.png
>
>
> When I run the code below with 3 statements with closures inside the method
> the local var (parameter) values (all 4 of them) are staying in memory.
> I don't see the same problem if I run corresponding Java code with lambdas.
> Run TestOOM.groovy with
> -Xmx600M -XX:+HeapDumpOnOutOfMemoryError
> Notice groovy fails:
> Y
> Z
> java.lang.OutOfMemoryError: Java heap space
> Dumping heap to java_pid147612.hprof ...
> Heap dump file created [497819587 bytes in 0.136 secs]
> Caught: java.lang.OutOfMemoryError: Java heap space
> java.lang.OutOfMemoryError: Java heap space
> at test.TestOOM.test(TestOOM.groovy:31)
> at test.TestOOM.run(TestOOM.groovy:41)
> But Java version does not.
> It looks like all the values of s are still in memory (see screenshot), even
> though previous values should be discarded.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
